KabaLabs / Cypress-Recorder

A dev tool that records user interaction with a web application and generates cypress code to allow the developer to replicate that particular session.
ISC License
658 stars 90 forks source link

Patch #135

Closed adam-stover closed 4 years ago

adam-stover commented 4 years ago

onInstalled listener was unnecessary. More importantly, resetting session.isPending to false needed to happen in a 'finally' clause instead of a 'then' clause in the control function. Otherwise an error anywhere in the chain had the potential to freeze the program in a pending state. Final change is removing '...args' and replacing with a single argument. Parcel compiles ...args into 'arguments' which is disallowed in strict mode and was unnecessary regardless, as there is never more than one argument to the callback.