search

Kaccana-Bhikkhu / qs-archive

A topic-tagged archive of audio questions and stories with Ajahn Pasanno of Abhayagiri Monastery
https://abhayagiri.org/questions
Other
0 stars 1 forks source link

Player closes in the middle of playing #73

Closed Kaccana-Bhikkhu closed 11 months ago

Kaccana-Bhikkhu commented 11 months ago

If one plays completely through an excerpt, the player window closes in 10 seconds. Even if you have already begun playing another excerpt.

To reproduce:

  1. Go to the Metta Retreat page.
  2. Play the first excerpt completely through (12 seconds long).
  3. Begin playing the second excerpt (6:21).
  4. The audio player closes in the middle of playing the second excerpt. I'm guessing this is due to the trigger set when the first excerpt finished playing.

I don't know enough Javascript to know how to cancel a timer. @mageowl, could you help with this when you get the chance? The next release will be in early January.

mageowl commented 11 months ago

Fixed in player-fixes-2. I save the timeout id from calling setTimeout and use clearTimeout to stop it from triggering.

Kaccana-Bhikkhu commented 11 months ago

@mageowl, thanks much for fixing this. I cherry-picked your fix into my current branch (version 3.7). I also brought player-fixes-2 up to date on github. Please pull these commits before doing futher work.

It will be a little while before the fix deploys on main.