Kacper-W-Kozdon / promptflow_unify_integration

1 stars 2 forks source link

Suggested improvements #1

Open KatoStevenMubiru opened 1 month ago

KatoStevenMubiru commented 1 month ago

@Kacper-W-Kozdon , Let me start with the setup.py, So I was reviewing the setup.py file and noticed a few minor things that could be improved:

Here's how the updated setup.py would look with these changes:

from setuptools import find_packages, setup

PACKAGE_NAME = "unify_integration"

setup(
    name=PACKAGE_NAME,
    version="0.0.12",
    description="Provides tools for integrating Unify AI with PromptFlow workflows.",  # Improved description
    packages=find_packages(),
    install_requires=["unifyai"],  # Added dependency
    python_requires=">=3.8",  # Specified Python version
    entry_points={
        "package_tools": ["unify_llm = unify_llm_tool.tools.utils:list_package_tools"],
    },
    include_package_data=True,
)

These are just some small suggestions to enhance the setup.py file. Let me know what you think!

Kacper-W-Kozdon commented 1 month ago

Description was a placeholder at that point :D Great suggestion with the handling of requirements, will do 👍

KatoStevenMubiru commented 1 month ago

Alright then