Bug Report: Downscroll hold notes doesn't appear correctly

[RowanSkie]

Please check for duplicates, similar issues or closed issues with the same problem, as well performing simple troubleshooting steps (such as deleting the export folder if it's an issue with compiling, reinstalling Kade Engine) before submitting an issue.

If you are playing a downloaded version of the game, what operating system are you using?

Windows 10 x86

What version of the game are you using? Look in the bottom left corner of the main menu.

Kade Engine 1.8

Have you identified any steps to reproduce the bug? If so, please describe them below. Use images if possible.

1. Set gameplay to downscroll.
2. Play any game with a long downscroll.

Please describe your issue. Provide extensive detail and images if possible.

1. Playing any song with a long hold note while in downscroll actually makes it seem like the downscroll is just a second long before suddenly popping the true length when played with upscroll.
2. This problem didn't exist in Kade Engine mods with 1.6 and previous.
3. Just generally annoying and causes a miss when noticed.

[BoloVEVO]

Download the Kade-Engine-Master that's KE 1.8.1 that has hold notes fixed in Downscroll (Only for Rate 1x), to get fixed in all rates go to PlayState.hx and replace "var stepHeight" with this.

var stepHeight = (0.45 * Conductor.stepCrochet * FlxMath.roundDecimal((PlayState.SONG.speed * PlayState.songMultiplier) * PlayState.songMultiplier,
                2));

I don't know how to do Pull Requests about this fix to merge it to master or stable idk. But here it is.

[RowanSkie]

Download the Kade-Engine-Master that's KE 1.8.1 that has hold notes fixed in Downscroll (Only for Rate 1x), to get fixed in all rates go to PlayState.hx and replace "var stepHeight" with this.

var stepHeight = (0.45 * Conductor.stepCrochet * FlxMath.roundDecimal((PlayState.SONG.speed * PlayState.songMultiplier) * PlayState.songMultiplier,
              2));

I don't know how to do Pull Requests about this fix to merge it to master or stable idk. But here it is.

Well, I know how to do Github, I could do a PR for this based on your code. Mind telling me what it does?

EDIT: tried it by creating a build and running Week 4's second song, which I knew had lots of hold notes. It works now.

[BoloVEVO]

Download the Kade-Engine-Master that's KE 1.8.1 that has hold notes fixed in Downscroll (Only for Rate 1x), to get fixed in all rates go to PlayState.hx and replace "var stepHeight" with this.

var stepHeight = (0.45 * Conductor.stepCrochet * FlxMath.roundDecimal((PlayState.SONG.speed * PlayState.songMultiplier) * PlayState.songMultiplier,
                2));

I don't know how to do Pull Requests about this fix to merge it to master or stable idk. But here it is.

Well, I know how to do Github, I could do a PR for this based on your code. Mind telling me what it does?

If you play in lower or higher rates than 1x, the hold line is insanely bugged. So this fix will attach properly the hold line sprite to the note in every rate in Donwscroll.

[RowanSkie]

So my problem actually may appear in differing scroll rates, besides downscrolling? huh.

[BoloVEVO]

So my problem actually may appear in differing scroll rates, besides downscrolling? huh.

Ye, and when you change Chart Scroll Speed in downscroll too. Downscroll is broken lol.

[BoloVEVO]

https://user-images.githubusercontent.com/88955176/154222676-a763064f-3862-474d-8cc5-245ee9729c07.mp4

It should be like this :D

[RowanSkie]

Oh wow. Well, your code definitely works. I created the PR now.

[BoloVEVO]

Oh wow. Well, your code definitely works. I created the PR now.

Making a pull request was so easy, I'm dumb. Thanks anyways!