search

Kagami / boram

:film_strip: Cross-platform graphical WebM converter
https://github.com/Kagami/boram/releases
433 stars 30 forks source link

Previous video keeps showing after new one is opened #26

Closed OrcaXS closed 5 years ago

OrcaXS commented 6 years ago

Platform: macOS 10.13.3 Built from source 4a8cba55d80866ffd29202c7490c2dd213d1b685 Since there's currently no building instructions I figured out the following one. (NaCl SDK installed and configured following https://github.com/Kagami/mpv.js)

yarn
./scripts/make-mac64-deps.sh
mkdir bin/mac64
cp -a scripts/dist/* bin/mac64/
yarn app
cp -a build/Release/boram.node dist/app/libboram.dylib
yarn dev
Kagami commented 6 years ago

Can you reproduce it with latest release build?

OrcaXS commented 6 years ago

No, the problem only exists when building from source. Looks fine in release build. Is there any problem with my building process?

Kagami commented 6 years ago

This might be because of updated mpv version. Please try

brew install mpv@0.27.0
cp /usr/local/lib/libmpv.1.dylib bin/mac64
OrcaXS commented 6 years ago

I tried https://github.com/Homebrew/homebrew-core/commit/1fd000f75cf53b9fef25eb447117e552fbd16bf8 because I can't install older version via brew install mpv@0.27.0. No luck.

But this time I checked console, following errors were logged when closing the tab. Closing the tab wasn't really closing the video, the audio was still playing.

image

Kagami commented 6 years ago

Ok, I will test build with latest mpv on Mac OS then.

Kagami commented 5 years ago

Just build boram v0.4.0-dev with mpv 0.29.0, seems fine to me. Except that if I open two videos, set to pause and switch between them, stop-frame is not updated. But that seems to be old issue.

Kagami commented 5 years ago

Could you try with latest boram v0.4.0 release? It uses mpv 0.29.0.

Kagami commented 5 years ago

Closing for now. Let me know if the problem still remains.