search

Kagami / boram

:film_strip: Cross-platform graphical WebM converter
https://github.com/Kagami/boram/releases
443 stars 27 forks source link

Replace legacy Youtube-dl with currently maintained yt-dlp #86

Open Aida-Enna opened 1 year ago

Aida-Enna commented 1 year ago

Replacing the included youtube-dl.exe with a renamed yt-dlp.exe made everything work as expected again and download fast. Based on this, this PR should fix the issue across all platforms with minimal changes, mostly comsetic (youtube-dl -> yt-dlp).

I modified the package stuff to include these as well, although I'm not sure why the python script is saved as a .zip. I also checked and there is a brew package for yt-dlp, so I swapped that as well.

Should fix #67 and #61, although I don't have a build environment set up for this to test it.

tutacat commented 1 year ago

This. YoutubeDL has still not updated it's releases, even though it works now, and yt-dlp is more frequently updated in general.