search

Kagami / vmsg

:musical_note: Library for creating voice messages
https://kagami.github.io/vmsg/
Creative Commons Zero v1.0 Universal
348 stars 58 forks source link

ensure the tracks on the stream are closed when the recording is stopped #17

Closed neilpoulin closed 6 years ago

neilpoulin commented 6 years ago

When using this in a browser, after initiating getUserMedia, the browser's "recording" indicator stays on since the stream's tracks are never stopped. This fixed that issue.

Kagami commented 6 years ago

Wow, thanks. I was trying to fix that issue too but didn't find a way.

Would that allow to do another recording without destroying the Recorder?

neilpoulin commented 6 years ago

Yep! On Tue, Aug 14, 2018 at 2:00 AM Kagami Hiiragi notifications@github.com wrote:

Wow, thanks. I was trying to fix that issue too but didn't find a way.

Would that allow to do another recording without destroying the Recorder?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Kagami/vmsg/pull/17#issuecomment-412787873, or mute the thread https://github.com/notifications/unsubscribe-auth/AAw-aoP-uwRx_18DzVnJ5SC7AsMe-nzkks5uQoOggaJpZM4V7su6 .

Kagami commented 6 years ago

Nice, thank you.