Kagamia / WzComparerR2

Maplestory online Extractor
MIT License
407 stars 134 forks source link

HTML Comparison sometimes does not account for <> brackets #214

Closed PirateIzzy closed 1 year ago

PirateIzzy commented 1 year ago

So I noticed that sometimes, the values inside a <> bracket are truncated in a comparison report, likely because the report assumes that we're adding HTML tags. For example, achievement 1422 merely says Obtain, while 1184 shows Complete <[Silent Crusade] Arkarium, the Guardian of Time>, likely because the first < is followed by a [

image

In WzCR2 itself, 1422 shows Obtain <Adventure Deep Dark Critical Ring>

image

Another example includes quests. Quest 36341 shows up as The book Wiz mentioned is a history book called the #b#k. in the comparison report, where the text <Chronicles of Ellin Forest> is truncated.

image

In WzCR2 itself, the text correctly shows up as The book Wiz mentioned is a history book called the #b<Chronicles of Ellin Forest>#k. image

And in game, it shows the text properly formatted with <Chronicles of Ellin Forest> in blue. image

Kagamia commented 1 year ago

Looks like all of the html texts are not escaped properly, add HtmlEncode for it.

PirateIzzy commented 1 year ago

Working now, thank you.