search

Kagamia / WzComparerR2

Maplestory online Extractor
MIT License
421 stars 134 forks source link

Adding script linked map teleport via Graph.img and custom MapRender UI Teleport #245

Closed PirateIzzy closed 8 months ago

PirateIzzy commented 11 months ago

This commit is a combination of these two PRs in WCR2-KMS by seotbeo: https://github.com/KENNYSOFT/WzComparerR2/pull/100 https://github.com/KENNYSOFT/WzComparerR2/pull/122

Video showcase https://www.youtube.com/watch?v=NASkC7jxQr0

Only question I have: should we change all of these (pName, pType, etc) into their Chinese equivalents? image

PirateIzzy commented 9 months ago

@Kagamia Just wanted to follow up, do you think we should change pName, pType, toMap, etc into their Chinese equivalents? I'll push an additional commit if so.

Kagamia commented 9 months ago

Really a fancy feature! I’m very sorry that I've no time to test it yet, but I think keeping the English label also looks good to me.

PirateIzzy commented 9 months ago

Really a fancy feature! I’m very sorry that I've no time to test it yet, but I think keeping the English label also looks good to me.

In that case, I might change "脚本链接地图" to "scriptMap".

PirateIzzy commented 8 months ago

Just pushed a new commit to implement all of the suggested fixes. I tested it and was able to run the MapRender successfully, including the new Graph changes.

Kagamia commented 8 months ago

Looks good to me, will merge this PR after manually veification.