KageJittai / lets-trade-5e

A Foundry VTT module which allows you to send and receive items from other players.
MIT License
11 stars 14 forks source link

Trading with NPC and autoaccepts. #22

Open grenadecx opened 2 years ago

grenadecx commented 2 years ago

Thanks for this amazing module.

I noticed the "Lack of support for trading with unclaimed player characters.". Is this anything that is being worked on? I think it would be a great addition to be able to send a trade request with an NPC or an "merchant" actor when you buy stuffs. If you implement this in the future, maybe consider an setting to enable autoaccepts on an actors as well.

KageJittai commented 2 years ago

The issue is rather complicated. A non-totally inclusive list of problems that need to be solved:

  1. DM control over which NPC sheets can be traded with and which can not.
  2. If they can be traded with, but not on every scene.
  3. Select NPCs from a list of extensive characters. (i.e. if the list of tradable targets is long, how can a player sort and select a character)
  4. NPC sheets do not show all item types. Making "hidden" items that can never be seen.
  5. NPC sheets do not show currency
  6. For "merchants," item prices will need to be set.
  7. NPCs understanding value over raw currency. If something is 10gp, it needs to accept 1pp or 100sp or 1000cp

Perhaps what needs to be done first, is to create a proper trade window, where both characters can make an offer at once, and only once both characters accept the pending offer the trade is complete. This would make merchant-style trading instead of freeform "give item" much easier.