Move JWE for user secrets to Kaggle Authorization header instead of r…

Kaggle / docker-rstats

Kaggle R docker image

Apache License 2.0

144 stars 90 forks source link

Move JWE for user secrets to Kaggle Authorization header instead of r… #127

Closed vimota closed 4 years ago

vimota commented 4 years ago

…equest body.

rosbo commented 4 years ago

Adding @Philmod as a reviewer since he is the owner of the R image.

vimota commented 4 years ago

Could you also add a similar change to kaggle/kaggle_bigquery.R?

Done!

vimota commented 4 years ago

LGTM for a quick fix, but could we add a proper test in a separate PR? A unit test (master/tests/test_bigquery.R), and/or a release test (http://shortn/_AufTDnI8SA)?

Added the unit test and will add a release test in a separate PR, thanks!