search

Kaggle / docker-rstats

Kaggle R docker image
Apache License 2.0
144 stars 90 forks source link

Unpin notebook. #180

Closed jplotts closed 2 years ago

jplotts commented 2 years ago

The referenced issue is closed.

http://b/211487924

Philmod commented 2 years ago

It's going to be tricky to merge this PR before we fix another issue that started on Feb 21. Just created a bug for it: https://b.corp.google.com/issues/224540778

Philmod commented 2 years ago

I merged my branch here which has 2 fixes for the CPU build.

jplotts commented 2 years ago

@Philmod - tests pass now with your fixes, thanks! Wdyt about merging this?

Philmod commented 2 years ago

@Philmod - tests pass now with your fixes, thanks! Wdyt about merging this?

Were you able to test it on kaggle? The problem is the GPU build is broken, so we wouldn't be able to deploy these new images. Is that ok?

jplotts commented 2 years ago

Yes, it seems to pass basic smoke tests: https://screenshot.googleplex.com/93eHpNq3mnMnj75

How long until we can deploy new GPU images? At some point, they will have to be deployed right? The R autocomplete work will be blocked until then.

jplotts commented 2 years ago

@Philmod - friendly ping

Philmod commented 2 years ago

Sorry about that, I missed you last message.