Fix GeneratePythonLibrary.sh script flow (`hatch run compile`)

jmasukawa commented 2 months ago

Issues:

hatch run install: properly generate the CLI executable. http://b/333027353
hatch run compile (GeneratePythonLibrary.sh) doesn't finish, and we're left with a mess of diffs.

Fix:

I compared the script before and after move (Webdiff)
Auditing all line diffs, one line caused the error pictured above. It seems sed -i .bak doesn't work for all versions of sed, and it was crashing the script, preventing the full compile flow from running.
Some linux versions seem to require sed -i.bak (without the space). Removing the .bak functionality allowed the script to finish.
FWIW I think it's fine to not create backups of the modified files, because we're version controlled anyways. 🤷

Screen capture of the flow after this change was made: k-api-compile-fixed

note at the end there's no generated diffs compared to what's checked in! 🙌

Philmod commented 2 months ago

Sorry about that! I'm wondering if that's because I implemented the migration/change on my mac?

jmasukawa commented 2 months ago

Sorry about that! I'm wondering if that's because I implemented the migration/change on my mac?

@Philmod ahh that explains a lot. no problem! it's good to catch this experience, since if the community tries to develop on the API they will hit similar things, when coming from different OS.

we talked about it internally, and we think the right answer is to have a public docker container for development on the API so everything is consistent.

Kaggle / kaggle-api

Fix GeneratePythonLibrary.sh script flow (`hatch run compile`) #563