Do not set environment variable globally in unittest to avoid side effects

Kaggle / kagglehub

Python library to access Kaggle resources

Apache License 2.0

42 stars 7 forks source link

Closed rosbo closed 2 months ago

rosbo commented 2 months ago

start_server is responsible to set the proper env variable.
use mock.patch.dict(os.environ, ...) instead of overwriting os.environ directly to avoid side-effects.
move away from using a global var for the server to enable using two servers if needed in the future (API + Colab).

neshdev commented 2 months ago

Can you also remove this code in b/344694700?