[Tool] Migrate tests to build in hatch test.

Kaggle / kagglehub

Python library to access Kaggle resources

Apache License 2.0

49 stars 9 forks source link

[Tool] Migrate tests to build in hatch test. #153

Closed dolaameng closed 3 weeks ago

dolaameng commented 3 weeks ago

Migrate from "hatch run test" script to "hatch test" builtin. Also migrate kagglehub off python 3.8- support.

Hatch 1.10+ supports builtin test by hatch-test env. This has several pros compared to our own implementation of tests as scripts. Details in the task. We removed the current test script but keep the docker-hatch functionality.
Stop support for python 3.7/3.8 so the api/tool usage is much clearer. TODO: migrate python code (b/360894076)

FIX=b/353580550

Tested

Test all python versions: hatch test --all
Test specific python versions: hatch test -i py=3.11
Integration tests: hatch test integration_tests -py 3.9

neshdev commented 3 weeks ago

Do you mean these scripts? https://screenshot.googleplex.com/RDAsjfEjQ8SoZq2

dolaameng commented 3 weeks ago

Do you mean these scripts? https://screenshot.googleplex.com/RDAsjfEjQ8SoZq2

Yes.

dolaameng commented 3 weeks ago

Thanks for working on this!

Can you also make sure to update our cicd pipeline to use the new commands:

https://github.com/Kaggle/kagglehub/blob/c0de979194b2e9a623644cf7021c47953ecc0ff6/tools/cicd/cloudbuild.yaml#L35-L36

And for the integration tests:

https://github.com/Kaggle/kagglehub/blob/c0de979194b2e9a623644cf7021c47953ecc0ff6/tools/cicd/integration-tests.yaml#L46

Sorry I think the same challenge here. If we still use the docker image built for python 3.7, we are forced to use an early hatch version, which doesn't support "builtin test".

dolaameng commented 3 weeks ago

@rosbo We have migrated the hatch support to Python 3.9+ and the implementation is much more straightforward. Now both hatch and docker-hatch use the builtin test functionality. Please have a final look. Thank you!