Kaggle / learntools

Tools and tests used in Kaggle Learn exercises
Apache License 2.0
447 stars 231 forks source link

SQL tutorial ex3 fixes #458

Closed mcbex closed 7 months ago

mcbex commented 8 months ago

I noticed exercise 3 in the intro to SQL tutorial was broken. The tutorial and exercise notebooks still reference the BigQuery public hacker news dataset comments table. This dataset has been updated and now only contains one table: full.

The first query in the exercise doesn't work as nicely using the full table because one of the columns used is called by and needs to be quoted. However this PR attempts to fix the issue by referencing the correct table and adding a note in the tutorial about reserved words.

Related discussion post on Kaggle: https://www.kaggle.com/learn/intro-to-sql/discussion/417044#2316394

Copy of the tutorial notebook with proposed changes applied: https://www.kaggle.com/mmcbex/sql-tutorial-3-updated

Fixes: https://github.com/Kaggle/learntools/issues/452

A couple follow up issues related to this one:

google-cla[bot] commented 8 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

pculliton commented 7 months ago

Thank you, Ming! We really appreciate this PR and your contribution.