Kaggle / learntools

Tools and tests used in Kaggle Learn exercises
Apache License 2.0
447 stars 231 forks source link

Bug in make_leads function #467

Open amir-keramatian opened 5 months ago

amir-keramatian commented 5 months ago

Bug in the following file: https://github.com/Kaggle/learntools/blob/master/learntools/time_series/utils.py

The function doesn't correctly create the leads. For example, setting leads to 1, it just copies the existing columns under a new column named: {name}_lead_0. See the attached screenshot for an example.

def make_leads(ts, leads, name='y'): return pd.concat( {f'{name}lead{i}': ts.shift(-i) for i in reversed(range(leads))}, axis=1)

image