Kaginari / terraform-provider-mongodb

Terraform provider for mongodb instance (selfhosted, AWS documentDB and cloud instances )
MIT License
26 stars 33 forks source link

Proposed Fix for #3 #4

Closed andiempettJISC closed 3 years ago

andiempettJISC commented 3 years ago

I found out of the box this provider wouldn't work with a different mongodb that wasnt configured in the way this provider assumes. changing the users role from readWriteAnyDatabase to readAnyDatabase resulted in an error. destroying the resource would work from terraform perspective but the user was retained on the mongodb.

found a few hardcoded vars and suggest using dropUser command to delete the user on update (there is a discussion about maybe updating the user in place but this PR doesn't address that)

just to say thanks for this TF provider as well!

ITMonta commented 3 years ago

thanks a lot for the contribution. :+1: i will review the changes and test the provider behaviour then merge the proposed fixes

ITMonta commented 3 years ago

@androidwiltron thank you again :) merged your changes