search

Kahbazi / MediatR.AspNetCore.Endpoints

MIT License
111 stars 12 forks source link

Support RouteData variables in request object #7

Closed mdissel closed 3 years ago

mdissel commented 3 years ago

See ticket #6

Kahbazi commented 3 years ago

Looks good. Could you please make this an opt-in feature, and add some unit tests?

mdissel commented 3 years ago

Could you please make this an opt-in feature,

I don't think this is necessary, because the developer is explicitly defining the variables in the Url. If you don't do that, no mapping will happen. Maybe only an opt-in for the possible override if there is a body / json handling.

and add some unit tests?

currently bit lack of time, but is indeed necessary.

Kahbazi commented 3 years ago

Thanks @mdissel. I will merge this PR and add the tests myself.

mdissel commented 3 years ago

Thanks! (didn't had the time yet to add the tests)