Add copy and paste functionality and small bug fixes

turtle-dov3 commented 3 years ago

Hi, I hope this is welcome! I really enjoyed your app and saw that you wanted to implement copy and paste so I thought I would give it a shot. :) feel free to give any feedback as you see fit. I know my color choices probably were not the best

Features added

allow a user to copy a single file or group of files from within the app to a new location in the save file list via right click or standard keyboard short cuts
allow user to paste a single file or a group of files from within the app to a different location. If the file already exists then the file name will be appended with (i) with i being the number of times that file has appeared

Bug fixes

when reloading from file system switching profiles would not work.
- cause: comparison of root folder objects was using default == and on re-load the profile objects are new causing a comp failure and eventual null point
- fix: adding equals method to save entries
When switching profiles sometimes file list would not get refreshed.
- cause: not 100% sure but I believe it has something to do with not refreshing the root folder object
- fix: assign the root folder to a new root folder object to force file list rebuild when switching profiles

Considerations for in the future

allow cut (ctrl+x) functionality
allow user to copy from outside app (like from the file system) and into the app.

Screenshots

Kahmul commented 10 months ago

Hey, I only just now got back to working on the organizer. I have released a new version that also includes Copy/Cut/Paste functionality with my own implementation, so I'll have to close the pull request. I did take some minor changes that you made and incorporated them myself. Thank you for taking the time!

turtle-dov3 commented 10 months ago

No problem at all totally understandable. Love the project btw. If you ever need any help feel free to reach out 👍

On Wed, Dec 20, 2023 at 6:27 AM Kahmul @.***> wrote:

Hey, I only just now got back to working on the organizer. I have released a new version that also includes Copy/Cut/Paste functionality with my own implementation, so I'll have to close the pull request. I did take some minor changes that you made and incorporated them myself. Thank you for taking the time!

— Reply to this email directly, view it on GitHub https://github.com/Kahmul/SoulsSpeedruns-Save-Organizer/pull/8#issuecomment-1864313594, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARQBU7EE74TYFPHUL3VFGXDYKLDTPAVCNFSM42LUBUD2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOBWGQZTCMZVHE2A . You are receiving this because you authored the thread.Message ID: @.***>

Kahmul / SoulsSpeedruns-Save-Organizer