Kai-46 / IRON

Inverse rendering by optimizing neural SDF and materials from photometric images
BSD 2-Clause "Simplified" License
299 stars 24 forks source link

About GGX Renderer #18

Closed changfali closed 2 years ago

changfali commented 2 years ago

Hi, I read the code and am confused about the BRDF implemented. Why the diffuse_rgb is compute like this:https://github.com/Kai-46/IRON/blob/8e9a7c172542afd52b8e6ef28bc96ad52b5ffd5a/models/renderer_ggx.py#L105, but not: light_intensity * (diffuse_albedo / np.pi) ? Could you introduce the meaning of other variables you used(Fdr, T12, T21, m_invEta2)? If the light and camera are not colocated, how to get the T21, T12?

Kai-46 commented 2 years ago

These equations are what we inherit from the Mistuba renderer. Please refer to MIstuba roughplasticBRDF for details.