In the Cook-Torrance BRDF
f_specular = D * F * G / (4 * (n dot v) * (n dot l)),
In the co-located setting, you assume v==l,
so the equation should be
f_specular = D * F * G / (4 * (n dot v) ** 2), right?
but in your code implementation,
https://github.com/Kai-46/IRON/blob/8e9a7c172542afd52b8e6ef28bc96ad52b5ffd5a/models/renderer_ggx.py#L69
it is
f_specular = D * F * G / (4 * (n dot v),
not f_specular = D * F * G / (4 * (n dot v) ** 2)
Could you have a look at this? @Kai-46
In the Cook-Torrance BRDF
f_specular = D * F * G / (4 * (n dot v) * (n dot l)),In the co-located setting, you assume v==l, so the equation should bef_specular = D * F * G / (4 * (n dot v) ** 2), right? but in your code implementation, https://github.com/Kai-46/IRON/blob/8e9a7c172542afd52b8e6ef28bc96ad52b5ffd5a/models/renderer_ggx.py#L69 it isf_specular = D * F * G / (4 * (n dot v), notf_specular = D * F * G / (4 * (n dot v) ** 2)Could you have a look at this? @Kai-46