Kai-46 / nerfplusplus

improves over nerf in 360 capture of unbounded scenes
BSD 2-Clause "Simplified" License
911 stars 101 forks source link

Poses are camera-to-world? #41

Open FreemanG opened 2 years ago

FreemanG commented 2 years ago

According to your data description:

Poses are camera-to-world, not world-to-camera transformations.

Then why does normalize_cam_dict.py save W2C in the cam_dict? Shouldn't it be C2W (cam to world)?

Kai-46 commented 2 years ago

You are right! You could get C2W easily by taking the inverse of W2C, and vice versa.

FreemanG commented 2 years ago

So I have to change this line

return np.linalg.inv(C2W)

to

return C2W

Is this right? The experiments seem better so far.

Kai-46 commented 2 years ago

Yes, or you could do such matrix inverses while converting the json camera file to text files.