KaiHabermann / decayangle

https://kaihabermann.github.io/decayangle/
MIT License
1 stars 0 forks source link

Test for 3 body helicity angles (Lc2pKpi) #32

Closed KaiHabermann closed 3 months ago

KaiHabermann commented 3 months ago

Closes #18

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.16%. Comparing base (45d01bf) to head (5fc6aa5).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #32 +/- ## ========================================== + Coverage 86.90% 87.16% +0.26% ========================================== Files 6 6 Lines 588 600 +12 Branches 102 103 +1 ========================================== + Hits 511 523 +12 Misses 42 42 Partials 35 35 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

KaiHabermann commented 3 months ago

So now your plan is to rotate what exactly? The dict have 4 angles per chain. But I dont know what they mean really

mmikhasenko commented 3 months ago

p(1)K(2)pi(3), we take [[2,3],1] kinematics as a reference

            "mkpisq": 1.3743747462964881,
            "theta_Kst": 1.0468159811504423,
            "phi_Kst": 1.3921357860994747,
            "theta_K": 1.692234518478623,
            "phi_K": 0.5466265769529981

rotations to be applied to the aligned kinematics are

Rz(phi_Kst) * Ry(theta_Kst) * Rz(phi_K) p_aligned

this way you compute p1, p2, p3, that we are going to pass to your angles function

KaiHabermann commented 3 months ago

Should work now. @mmikhasenko could you have a quick look?