KaiHabermann / decayangle

https://kaihabermann.github.io/decayangle/
MIT License
1 stars 1 forks source link

Change the name and order of the helicity angles #55

Closed KaiHabermann closed 4 months ago

KaiHabermann commented 4 months ago

They were called (theta_fr, psi_rf). But the represent a rotation R(psi_rf) R(theta_fr) R(0). We represent and call rotational argumentes R(phi_rf) R(theta_rf) R(psi_rf) Thus the naming is misleading. This change is of course breaking things for users. Thus a change in version to 1.1.0 will happen once this is build in.

codecov-commenter commented 4 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.08%. Comparing base (54aa23f) to head (d45b329).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #55 +/- ## ======================================= Coverage 88.08% 88.08% ======================================= Files 6 6 Lines 646 646 Branches 113 113 ======================================= Hits 569 569 Misses 41 41 Partials 36 36 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.