KaiHabermann / decayangle

https://kaihabermann.github.io/decayangle/
MIT License
1 stars 0 forks source link

Is `frame` the right term for it #8

Closed mmikhasenko closed 5 months ago

mmikhasenko commented 5 months ago

The Wigner rotation that we compute gives rotation between two coordinate systems, in a rest frame of a particle.

in the example https://github.com/KaiHabermann/decayangle/blob/6c9e83dcf535b91b0f155a9964bac1230b20abe6/tests/test_lorentz.py#L189-L192

    frame1, = tg.filter((2,3))
    frame2, = tg.filter((1,3))
    frame3, = tg.filter((1,2))

are decay_chains, or decay_topologys, rather then frames

KaiHabermann commented 5 months ago

Yes you are certainly correct. The class is called Tree aswell (as in decay tree). So I think I will rename to tree1 etc.

KaiHabermann commented 5 months ago

I will make a MR with name changes and you tell me, if you roughly know what things are, by name alone. I think this is the best we can get before we make the thing public and get input from reall people

KaiHabermann commented 5 months ago

I will stay with tree for the class names. Tree is the general name, while chain can be used for three body decays. For four body we can have trees, where two independent decay can occur. Thus chain is not really fitting anymore.

   |-> (1, 2) -> 1, 2
0--|
   |-> (3, 4) -> 3, 4
   |-> (1, 2) -> 1, 2
0--|
   |-> 3
KaiHabermann commented 5 months ago

I now changed tree to topology. I think it is clearer. will merge and close this Issue