search

KaiKikuchi / QuickShop

A shop plugin for Bukkit
47 stars 41 forks source link

Stone:1 shop should say "Granite" #121

Closed smmmadden closed 7 years ago

smmmadden commented 7 years ago

image image

Stone:2 should say "Polished Granite" or "Smooth Granite" image

smmmadden commented 7 years ago

Stone:3 should also be "Diorite" image Stone:4 should also be "Polished Diorite" or "Smooth Diorite" image

smmmadden commented 7 years ago

Stone:5 should read as "Andesite" image Stone:6 should read as "Polished Andesite" or "Smooth Andesite" image

smmmadden commented 7 years ago

image

smmmadden commented 7 years ago

should you be able to make the changes I've reported, do let me know how I can donate $ to your time. I gladly support those who supports the server owners. :-)

KaiKikuchi commented 7 years ago

Welp.

Unfortunately Bukkit API doesn't provide a good way to show item names, that is why they're all so messed up.

I'm sorry you had to make all those screenshots, but actually you should take advantage of this section on the config file: https://github.com/KaiKikuchi/QuickShop/blob/master/src/main/resources/config.yml#L102-L105

And basically set those items name manually on the config.

smmmadden commented 7 years ago

Okay, I'll go through the steps of doing that but if this is a known issue wouldn't it be better to provide them already in the file so that server owners don't have to? This is one of those conditions where as a developer, does it make sense for hundreds of people maybe even thousands, make the exact same changes, or make the change once and provide to everyone? I'm happy to get them all listed and share it back with you so everyone can benefit from it that works for you?

KaiKikuchi commented 7 years ago

wouldn't it be better to provide them already in the file so that server owners don't have to?

If only they worked on all different minecraft versions... also I really do not have time for naming items so I gave server owners the ability of naming items. It is very useful for localization.

I'm happy to get them all listed and share it back with you so everyone can benefit from it that works for you?

That may help a lot of other server owners! Be sure to specify your server version.

smmmadden commented 7 years ago

I just tried adding them but getting invalid custom item name definitions for each one. I checked the spigot page you provided (thanks) so I think this may be a spigot issue that they are not listed or at least not with proper names. :-) custom-items-name:

I'll see what I can get from Spigot for updating 1.11.2 with the correct names for the above. Will let you know what they say.