search

KaiKikuchi / QuickShop

A shop plugin for Bukkit
47 stars 41 forks source link

Shop signs not refreshing #128

Closed PyvesB closed 7 years ago

PyvesB commented 7 years ago

Hello KaiKikuchi,

I have just downloaded version 0.9.31 and tested it on three different servers (respectively featuring Minecraft versions 1.11.2, 1.12-pre5 and 1.12-pre6). Two of them are running the default plugin configuration.

Unfortunately it seems as if the shop signs are no longer updated when a player clicks on them. For instance, suppose I create an empty shop selling a specific item. After putting a stack of that item inside, the shop keeps on showing "Selling 0" no matter what. Everything works as expected when reverting back to version 0.9.29.

Am I doing something wrong or was a regression introduced in the latest version?

Thanks in advance,

Pyves

KaiKikuchi commented 7 years ago

Hey. Thank you for your report. Perhaps you need to update your messages.yml file (backup it first). Try deleting it and restarting the server. Also when clicking the sign, check the server log: some exception may suggest what is causing the issue.

PyvesB commented 7 years ago

On the two servers I mentioned which were "running the default plugin configuration", I did delete the entire QuickShop folder and performed a full server restart.

I did not see any stack traces or notice any usual log messages related to QuickShop in the logs.

KaiKikuchi commented 7 years ago

Can you attach your server log?

PyvesB commented 7 years ago

Here is the startup log of the 1.12-pre6 server, even though I'm not convinced there's anything interesting inside: https://gist.github.com/PyvesB/e013fa3d5594e705c2c1ed3746a9f1e2

KaiKikuchi commented 7 years ago

Thank you for your report. The issue will be fixed shortly.

KaiKikuchi commented 7 years ago

Fixed in version 0.9.32

PyvesB commented 7 years ago

Awesome, thanks!