search

Kaiede / PlexPlaylistHost

Plugin to make PLEX music playlists available to UPnP/DLNA Clients.
MIT License
12 stars 3 forks source link

Forgot to update the README file 😇 #7

Closed D43m0n closed 3 years ago

D43m0n commented 3 years ago

Thank you for accepting the pull request. This morning I remembered I forgot to update the README file to explain the third, new setting and how to use it. So I've done that in this pull request.

I've also taken the liberty to find a free to use icon (free for personal and commercial use) if attribution is made. I've selected an icon as a replacement for the placeholder which seems to fit in the color scheme on Plex' interface. The attribution is added in the README file under the License section.

Kaiede commented 3 years ago

The Readme changes look good, but will need more details on the icons. Can you provide links to the specific icons that were used so I can review the license?

My concern here is that licenses for free icons can sometimes have restrictions that can make them unsuitable for a project like this one.

D43m0n commented 3 years ago

Sure!

here’s the specific page describing the icon, the license and the attribution terms.

Kaiede commented 3 years ago

Thanks, I've gone ahead and make sure the merge commit contains the link for the icon to make it easier to track down in the future.