KaiserKarel / substrace

Static analysis for Substrate based projects
27 stars 1 forks source link

Add the extrinsics-must-be-tagged lint and subcommand to detect extrinsic reorderings #13

Closed KaiserKarel closed 1 year ago

KaiserKarel commented 1 year ago

Currently, extrinsics should never be reordered, unless we add an explicit tag to ensure that the serialization remains the same. We need a lint that forces this tag to be added.

Untagged extrinsic: https://github.com/ComposableFi/composable/blob/4e1ca505a59d914cc37d3571f0aefa1eb7cf2218/code/parachain/frame/assets/src/lib.rs#L178