Kaiserreich / Kaiserreich-4-Bug-Reports

Issue tracker for Kaiserreich for Hearts of Iron 4
110 stars 40 forks source link

SIK/GXC - allow Xinjiang to be invited to the Feds Conference, but only if XSM is also invited #13501

Closed El-Daddy closed 3 years ago

El-Daddy commented 3 years ago

Quick questions HOI4 version: Newest Kaiserreich version: Master

Describe the change you would like: So I thought of a potential solution to the SIK joining the UPC problem.

So this is the code that has been removed, that previously invited them to the conference..

Screenshot_20210127-112257

What if a clause was added into this, that they would only get the invite if XSM was not NatPop? (ie, XSM is invited too). That way, SIK will only be invited if there another neighbouring tag (XSM) with an accessible border there too.

Explain the reasoning behind this change: This will allow SIK to still attend the conference if it is not lead by Jin Shuren, as was intended originally. As XSM will also be in the same faction, there is no worry of SIK being isolated from everyone else, without a border.

Additional context or comments: Alternatively, SIK could still join the conference as always, even without XSM joining. However, if ETS or TAN capitulate SIK, then ETS and TAN also white peace with the rest of UPC, so the war doesn't go on. UPC members could have the option of sending volunteers to SIK if they don't have a land border, to help them out if they so wish.

This would also get rid of the edge case scenario of player-XSM who is not NatPop, choosing to not go to the conference.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it was created more than a month ago. Any dev is now free to relabel, close or implement it.

Alpinia commented 3 years ago

Added.