Kaiserreich / Kaiserreich-4-Bug-Reports

Issue tracker for Kaiserreich for Hearts of Iron 4
110 stars 40 forks source link

CHI - Issues with KMT autonomy over MON, XSM, and TIB. #13527

Closed ghost closed 3 years ago

ghost commented 3 years ago

Quick questions OS: Windows 8.1 HOI4 version: 1.10.3 Kaiserreich version: Dev master 28.01.21 List any other mods used: None Were you using Steam? Yes Were you in multiplayer? No Which expansions do you NOT have? La resistance, BFTB

Explanation of the issue: After a tip from the discord, about MON_KMT cosmetic tag not appearing after MON agree's to be autonomus- and of issue with Autonomus XSM; thus I decided to quickly check those myself and see the issues with them, and I have listed them here:

1. when XSM is offered Autonomy and it accepts it, 2 odd things happen- 1st is that their goverment is changed, thus leading them to become the same party as KMT, which causes them to have a Generic leader- it seems more fitting that they would keep their current goverment, just like how the other autonomies work. (see pictures 1 and 2) 2nd is that if they have MON and TIB as puppets, MON and TIB will become indepedent, which is quite odd, again as they have puppet leaders of their own. (see pictures 3 and 4)

2. When MON agrees to autonomy under KMT, they do not get the MON_KMT flag, like it seems they should. (see pictures 5 adn 6)

3. When TIB agrees to be a KMT autonomy, it does not get the TIB_KMT flag as well, instead retaining their former flag (see pictures 7 and 8)

4. This is more of a suggestion than a Bug, but I suggest that if MON agrees to be a KMT autonomy, that they switch their focus tree to the Mongolia_Puppet one, and unlock the focus MON_kuomintang (maybe this could be only done if MON is ai or something)

Steps to reproduce:

  1. play CHI, take autonomus areas

  2. Make an agreement for autonomy with XSM, MON and TIB, and see if these issues appear again.

Possible cause:

  1. I suspect the issue here is that event chi_for.37 just has the puppet effect on XSM, rather than having the the get_current_government_type and restore_previous_government_type effects, as well as not having them transfer their puppets to CHI, thus causing them to become free.
            CHI = {
                puppet = XSM
            }

    2. the issue here simply seems to be that event chi_for.52 does not give MON the MON_KMT cosmetic tag, leading them to staying as normal mongolia.

3. As it seems that TIB is handled by the same event chi_for.52, there needs to be a check so TIB will get the TIB_KMT cosmetic tag if it agrees to become CHI puppet in that event.

Screenshots:

ghost commented 3 years ago

I didn't code these aspects so I am unaware of how they function, that said once I am no longer busy I will have a look into these issues.

emwe39 commented 3 years ago

did some research on this, looks like while the MON_KMT and TIB_KMT cosmetics are defined, there is no code anywhere that would actually set those cosmetics for the tags.

enemy puppets not being part of the peace conference if you haven't touched their land is vanilla behaviour, btw.

ghost commented 3 years ago

enemy puppets not being part of the peace conference if you haven't touched their land is vanilla behaviour, btw.

there was no peace confrence in this case- as said XSM became a puppet by event- event chi_for.37 in this case, but released their Mongol and TIB puppets, instead of transfering them to CHI- since XSM will almost always have TIB and MON as puppets if they survive up to this point, this seems like its a significant issue

emwe39 commented 3 years ago

partially fixed, Tibet and Mongolia get their KMT cosmetic tags now

Alpinia commented 3 years ago

Fixed.