Kaiserreich / Kaiserreich-4-Bug-Reports

Issue tracker for Kaiserreich for Hearts of Iron 4
110 stars 40 forks source link

Many nations - Duplicated localization keys 0.16.1 #13716

Closed NicolasGrosjean closed 3 years ago

NicolasGrosjean commented 3 years ago

Quick questions OS: Windows 10 HOI4 version: 1.10.4 Kaiserreich version: 0.16.1 List any other mods used: None Were you using Steam? Yes Were you in multiplayer? None Which expansions do you NOT have? Battle for Bosphorus

I have improved my Python script to find duplicates in localization shown in #13143 : now it finds duplicates recursively in the directories, that's why there is KR_Vanilla_Override_l_english.yml in the following lists contrary to before.

The list of 15 buggy localization keys ``` BAT_export_agriculture_desc is duplicated. Found at least once in KR_Baltic_Duchy_l_english.yml acr_tech is duplicated. Found at least once in KR_Equip_Naval_l_english.yml government is duplicated. Found at least once in KR_Vanilla_Override_l_english.yml low_economic_mobilisation is duplicated. Found at least once in KR_Vanilla_Override_l_english.yml partial_economic_mobilisation is duplicated. Found at least once in KR_Vanilla_Override_l_english.yml tot_economic_mobilisation is duplicated. Found at least once in KR_Vanilla_Override_l_english.yml generic_army_regrouping is duplicated. Found at least once in KR_Vanilla_Override_l_english.yml generic_tank_manufacturer is duplicated. Found at least once in KR_Vanilla_Override_l_english.yml generic_motorized_equipment_manufacturer is duplicated. Found at least once in KR_Vanilla_Override_l_english.yml idea_category_political is duplicated. Found at least once in KR_Vanilla_Override_l_english.yml idea_group_armor is duplicated. Found at least once in KR_Vanilla_Override_l_english.yml idea_group_armor_desc is duplicated. Found at least once in KR_Vanilla_Override_l_english.yml idea_group_motorized is duplicated. Found at least once in KR_Vanilla_Override_l_english.yml idea_group_motorized_desc is duplicated. Found at least once in KR_Vanilla_Override_l_english.yml political_advisor is duplicated. Found at least once in KR_Vanilla_Override_l_english.yml ```
The list of 5 non-buggy (same text value) localization keys ``` military_staff is duplicated. Found at least once in KR_Vanilla_Override_l_english.yml mobilization_laws is duplicated. Found at least once in KR_Vanilla_Override_l_english.yml aircraft_manufacturer is duplicated. Found at least once in KR_Vanilla_Override_l_english.yml materiel_manufacturer is duplicated. Found at least once in KR_Vanilla_Override_l_english.yml industry_concern is duplicated. Found at least once in KR_Vanilla_Override_l_english.yml ```

Thanks a lot to have fixed the 118 duplicated keys in #13143, it has fixed some bugs and reduced manual operations I was doing after applying scripts to update French localization.

Alpinia commented 3 years ago

Fixed.