Ideas equipment_bonus check

[Pelmen323]

Quick questions Kaiserreich version: master pulled 11.05.2021

Describe the specific change you would like: A set of tests was performed to ensure the bonuses granted by producer traits are valid and actually applied to equipment. Each listed scenario was tested: Motorised equipment stats:

        maximum_speed = 12
        reliability = 0.8
        hardness = 0.1

        #Space taken in convoy
        lend_lease_cost = 5

        build_cost_ic = 2.5
        resources = {
            #oil = 1
            rubber = 1
            steel = 1
        }

        fuel_consumption = 1.2

• [x] motorised_equipment_producer_defense_0, motorised_equipment_producer_defense_1, motorised_equipment_producer_defense_2 - replace "defense" stat of motorized_equipment Reason: motorized_equipment doesn't have "defense" stat (units\equipment\motorized.txt), maximum_speed, reliability, hardness and build_cost_ic are the only ones motorized_equipment has, so actually assigning the designer with this idea doesn't change anything (as motorised battalion uses stats from infantry equipment except the mentioned ones)

• [x] us_motorized_companies_buick - replace "armor_value" stat of motorized_equipment Reason: the same, motorized_equipment doesn't have armor_value stat

• [x] us_motorized_companies_marmon_herrington - replace "defense" stat of motorized_equipment Reason: the same

• [x] us_motorized_companies_hudson - replace both soft_attack and defense stats of motorized_equipment, soft_attack from mechanized_equipment, amphibious_mechanized_equipment Reason: the same, motorised doesn't have the mentioned stats, and mech/amtrack doesn't have soft_attack stat. Mech/amtrac have inbuild +10% soft attack bonus, but other attack bonuses except the one in the tech tree are not applied.

• [x] cos_school_of_manoeuvre (common\country_leader\minister_traits.txt) trait (+10% soft attack to mot and mech equipment) doesn't work, replace it with something Reason: the same that mentioned earlier, mot/mech equipment doesn't have their own soft_attack stat 6 is the base value of soft attack for 1 battalion of motorised with 1936 infantry equipment. Nothing changed after the COS was assigned

• [x] GEO_armor_school idea - replace soft_attack = 0.05 from motorized_equipmen tequipment_bonus Reason: motorized_equipment doesn't have soft_attack stat

• [x] SFR_greatest_mechanized - remove breakthrough = 0.10 from motorized_equipmen tequipment_bonus Reason: motorized_equipment doesn't have breakthrough stat

• [x] NATFRA_Ineluctable_Advance_idea - remove breakthrough = 0.10 from motorized_equipmen tequipment_bonus Reason: motorized_equipment doesn't have breakthrough stat

[Alpinia]

Fixed.