Kaiserreich / Kaiserreich-4-Bug-Reports

Issue tracker for Kaiserreich for Hearts of Iron 4
110 stars 40 forks source link

Germany, Fixing SIC inconsistency ingame #21634

Closed Generalkaiser closed 1 year ago

Generalkaiser commented 1 year ago
Please Note (click to expand) Suggestions that don't match this template will be closed. We understand this can seem harsh, but in order to ensure we are able to keep on track of bugs other serious issues it is vital our issue tracker is kept organised. The kinds of suggestions that will get close and directed elsewhere include, but are not limited to: - Anything that suggests adding new content - Anything that is focused around changing lore - Anything that will take a significant amount of time to implement - Anything that isn't specific and actionable change about existing content, as the template specifies Please know that this isn't out of any disrespect for the ideas you might have for the mod, and encourage people with a passion to get involved either on the subreddit, the discord or even via joining the team itself. But that being said, suggestions that don't match this template will be closed.

Quick questions HOI4 version:
Kaiserreich version:

Describe the specific change you would like: Change either the partydiscription of the DKP or add Von Westarp to the game

Explain the reasoning behind this actionable change: In the current German setup Franz von Papen is the second-in-command a slot reserved for reichskanzler as far as I know. With the rework in progress lore is ofc gonna change but on the wiki and in the party description of the DKP von Westarp is mentioned as Reichskanzler. To fix this inconsistency I would guest either adding Von Westarp as a new option and making him the stating second-in-command (this would require new GFX is might be a bit to much effort). Another option is just taking out the mentioning of von Westarp being appointed and reelected to make the ingame situation consistent by not stating who the reichskanzler is.

Additional context or comments: For the loc change I would suggest making the line for the party discription the following:

GER_authoritarian_democrat_party_long: "Deutschkonservative Partei\n§gThe DkP (German Conservative Party) was founded in 1876, being extremely influential during the Bismarck era, leading the shift towards protectionism. However, after 1912 the party was unable to become the leading party of the right, which caused the formation of the DVLP, which usurped a lot of DkP members. The DkP was initially a supporter of the Ludendorff dictatorship but turned against it in the 1920s.\n\nAfter the 1923 elections, the DkP under Ernst von Heydebrand und der Lasa and Kuno Graf von Westarp reluctantly joined the Great Coalition of von Tirpitz. After the 1928 elections, Kuno von Westarp, under the pressure of the growing DVLP began the process of modernising the DkP to also attract urban right-wing voters and reform into a conservative-tent party. With it even backing an expansion of social welfare, though it also is in favour of cutting spending, except for agricultural subsidies. The last few years have been quiet, with as little change as possible. The party continues to support the centralisation of the Empire and strictly opposes voting reforms.§!"

This is then deleted from the current setup: After the surprising death of von Tirpitz in 1930, the Kaiser picked von Westarp as his successor. Following two years of uneventful rule, the German electorate voted to let von Westarp be the new administrator and keeper of its wealth. Kuno von Westarp has done as was demanded, and

For adding Von Westarp that would require more changes including but not limited to:

In loc changing Von Papen to Von Westarp OLD: gerdom.36.a: "Von Papen is doing a fine job." NEW: gerdom.36.a: "Von Westarp is doing a fine job."

OLD: gerdom.40.e: "Another chance for Franz von Papen!" NEW: gerdom.40.e: "Another chance for Kuno Graf von Westarp!"

OLD: GER_security_prerequisite: "Either §YFranz von Papen§! or §YKurt von Schleicher§! is the head of government." NEW: GER_security_prerequisite: "Either §YKuno Graf von Westarp§! or §YKurt von Schleicher§! is the head of government."

OLD: gerdom.30.d: "Under the constitution of 1871, there is no formal government in the Kaiserreich. Instead, the Kaiser appoints a person of his liking to the post of Reichskanzler, who then fills the state secretary posts of the 'Reichsleitung' - the 'Reich administration'.\n\nEven though the DkP defended their Reichstag majority in the elections, this does not mean the Kaiser has to keep Franz von Papen. What shall we do?" NEW: gerdom.30.d: "Under the constitution of 1871, there is no formal government in the Kaiserreich. Instead, the Kaiser appoints a person of his liking to the post of Reichskanzler, who then fills the state secretary posts of the 'Reichsleitung' - the 'Reich administration'.\n\nEven though the DkP defended their Reichstag majority in the elections, this does not mean the Kaiser has to keep Kuno Graf von Westarp. What shall we do?"

Adding him as an advisor (without GFX because I don't think he is currently in the mod:

GER_Characters: Add: GER_kuno_graf_von_westarp = { name = GER_kuno_graf_von_westarp portraits = { army = { small = } } advisor = { slot = second_in_command idea_token = GER_kurt_von_schleicher_sic traits = { traits = { KR_ephialtes_of_zentrum_sic second_in_command_trait } cost = 0 removal_cost = -1 on_add = { second_in_command_on_add = yes } on_remove = { second_in_command_on_remove = yes } } }

History: recruit_character = GER_kuno_graf_von_westarp OLD: activate_advisor = GER_franz_von_papen_sic NEW: activate_advisor = GER_kuno_graf_von_westarp_sic

Making localisation: GER_kuno_graf_von_westarp: "Kuno Graf von Westarp"

Generalkaiser commented 1 year ago

I've no tested everything here because I assume that if this is added the party description will just be eddited, but if required I could check everything to get it to work. I could also get the files changed and added here to make this happen. Except GFX because I'm not able to make a picture Kaisserreich style.

Augenis commented 1 year ago

the mention of Westarp in the loc was done only because he was going to be the reichskanzler in the dilapidated rework, there's no reason to add him into the mod. the loc will be edited.