Kaiserreich / Kaiserreich-4-Bug-Reports

Issue tracker for Kaiserreich for Hearts of Iron 4
110 stars 40 forks source link

RUS - Moscow peace shenigans #24089

Open popodaet opened 8 months ago

popodaet commented 8 months ago

OS

Windows 11

HOI4 Version

1.13.6

Kaiserreich Version

1.0.3

List any other mods used

KR music/model mods, show speed in construction view

Were you using Steam?

Yes

Were you in multiplayer?

No

Which expansions do you NOT have?

None

Explanation of the Issue

  1. When Reichspakt reaches peace with Russia, AI Transamur also peaces while it's supposed to stay at war.
  2. When Russian faction collapses, its members still stay at war with previous non-RP Russian enemies, some of which span across continents (e.g. Transamur vs Afghanistan) and don't really make sense.

Steps to reproduce

  1. Load the may 25th save, which already has the event presented
  2. Accept the peace, observe the weird behavior or previous Russian allies/enemies and Transamur.

Possible Cause

  1. In event rusfor.1308, the chance for Transamur to say yes and no to Russian peace is both 0, so hoi4 just picks the first option yes. Should change the AI chance for no to 1 for transamur
  2. The non-RP peace rusfor.1308 is fired only after Russia's faction collapsed, so the leftover war relations are still there and there's no nice way to clean up. Maybe use a country flag to track the previous allies and handle peace case-by-case or perform faction disbanding in the end of RUS_fire_next_moscow_treaty_event_no_rp effect loop so everyone peaces out.

IMO peacing out everybody is ok, because the wars should be started by repeatable decisions and they can probably click those decisions again; or we can allow Germany to bring in non-rp countries in the negotiation event chain (to ask Russia to cede more land, maybe? Such as to expansionist Mongolia)

Screenshots

image Previous Russian allies (East Turkestan, previous puppet Afghanistan) still at war with previous Russian enemies (Transamur, Iran + Armenia)

Save File

moscow-peace-bugs.zip This zip contains 2 files: the Feb 7 one is a normal save; the May 25 one was after I used commands to make Russia reach capitulation faster (because I forgot to save during my enjoyable gameplay where I infantry-encircled 10 russian infantry divisions)

Log Files

No response

Important Files Attached

popodaet commented 7 months ago

Also for reference https://discord.com/channels/189497851057799168/274271541171322891/1204137804452597801 RadSoc Ukraine in revolt gets the rusfor.1308 non-RP peace, and doesn't get any claim from Russia. This case might need more considerations as well.

Matihood1 commented 6 months ago

I just want to add that this bug is still active to a degree. In my last run (KR v1.1), a non-aligned Albania, which declared a war on Serbia (which was in the MA) after the 2WK kicked off, stayed at war with Ungern-Sternberg's Mongolia after the Russian peace deal triggered.