Kaiserreich / Kaiserreich-4-Bug-Reports

Issue tracker for Kaiserreich for Hearts of Iron 4
110 stars 40 forks source link

CHI, FNG - "Dividing the Spoils of War" event firing despite no negotiations #6267

Closed shockz0rz closed 4 years ago

shockz0rz commented 4 years ago

Quick questions OS: Windows 10 HOI4 version: 1.8.1 Kaiserreich version: 0.10.1 List any other mods used: KR music mods, Sensible Political Maps, State Transfer Tool Were you using Steam? - Yes Were you in multiplayer? - No Which expansions do you NOT have? - Have all currently released expansions.

Explanation of the issue: If the Left Kuomintang defeats Qing in a defensive war (i.e. Qing declares) without Fengtian having declared on Qing, the event titled "Dividing the Spoils of War" will fire for the LKMT. The event implies that negotiations were made with Fengtian to split Qing after its defeat; I'm assuming it's supposed to fire if the player selects the "Negotiate with Marshal Zhang" focus. However, it will fire even if the player has not yet taken any focuses past "Prepare for the 2nd Northern Expedition", allowing Fengtian to take a great deal of land for free.

Steps to reproduce:

  1. As the LKMT, get declared on by Qing (may not need to be a defensive war, see possible causes below) prior to taking the "Negotiate with Marshal Zhang" focus.

  2. Win the war prior to Fengtian declaring war on Qing and take Beijing.

Possible cause:

The chi_fng.15 event fires upon

trigger = {
        tag = CHI
        is_subject = no
        country_exists = FNG
        NOT = {
            country_exists = QIE
            has_war_with = FNG
        }
        OR = {
            owns_state = 1060
            owns_state = 1061
            owns_state = 615
            owns_state = 1063
            owns_state = 1062
            owns_state = 608
            owns_state = 611
            owns_state = 614
        }
    }

I am completely inexperienced with HOI4 modding, but to me it doesn't appear that there's any kind of check that CHI has, in fact, agreed to split QIE with FNG--only that QIE no longer exists, CHI is not at war with FNG, and CHI owns former QIE states north of the Yellow River.

Screenshots: On the edge of victory, FNG not in war

Peace conf

Focus tree, no negotiations made

u wot now

ghost commented 4 years ago

That event had a flag ensuring it would only fire if they did the negotiations, I swear this existed before but I can re add it.

ghost commented 4 years ago

Fixed.