Unconverted Encryption and Decryption Bonuses

[Myrten]

Explanation of the issue: There are quite a lot of national spirits with bonuses to encryption/decryption or encryption/decryption techs. I'm pretty sure they no longer do anything for people with LaR so they need to be replaced with other effects.

My quick search found them in these idea files:

In vanilla US idea office_of_strategic_services got two separate versions for players with and without LaR so I guess that's how it should be changed.

Checklist

• [x] TEX - American Union State
• [x] AST - Australasia
• [x] BRA - Brazil
• [x] BHC - Bharatiya Commune
• [x] CAN - Canada
• [x] CSA - Combined Syndicates of America
• [x] DOM - Dominican Republic
• [x] DEI - Dutch East Indies
• [x] FNG - Fengtian
• [x] FIN - Finland
• [x] FRA - France
• [x] INC - Indochinese Union
• [x] CHI - Left Kuomintang
• [x] LIB - Liberia
• [x] MEX - Mexico
• [x] MON - Mongolia
• [x] PAP - Papal States
• [x] ITA - Republic of Italy
• [x] RUS - Russian Republic
• [x] SZC - Sichuan
• [x] SRI - Socialist Republic of Italy
• [x] SWE - Sweden
• [x] TIB - Tibet
• [x] SIC - Two Sicilies
• [x] GBR - United Kingdom
• [x] USA - United States of America
• [x] URG - Uruguay
• [x] VNC - Venetian
• [x] VIE - Vietnam
• [x] WHR - White Ruthenia
• [x] SIK - Xinjiang
• [x] YUC - Yucata
• [x] ministers

[Zankoas]

Should be 110% they do nothing with LaR, but if that is the case those should be changed. The vast vast majority of our players play with the DLC and so that is who we should target

[Vidyaorszag]

Fixed FRA and WHR

[Alpinia]

Fixed SZC, RUS, USA, TEX, CSA.

[Alpinia]

Fixed SWE, FIN, DEI, BRA, URG, MON.

[Zankoas]

Note that @BugBot3000 has found it still does have some effect, it's just a bit odd:

Doesn't seem it is hooked in too well, so I think we are still go with conversation

[Myrten]

Note that @BugBot3000 has found it still does have some effect, it's just a bit odd:

Doesn't seem it is hooked in too well, so I think we are still go with conversation

Are you sure that's not from decrypting cypher in Cryptology department?

[BugBot3000]

@Myrten nah I didn't even take the thing to be able to decrypt anything, setting aside I'm the Zhili Clique and wouldn't decipher Germany. I could see all focus trees with my decryption +1 where the country did not have a minister or any other buff towards decryption. My guess is that this is how vanilla without La Resistance works and all PDX did was hide the techs if you have La Resistance.

[Pietrus69]

If non-dlc owners can get access to the new modifiers, I would rather just keep it how it is for the DR.

[PPsyrius]

If the older bonus still affects stuff then there's no need to change out the minister effects I guess. Making two separate version of certain ministers would be an ass to maintain too.

[Zankoas]

Wait wait nono; not having a system for all nations apart from DR, that's not how standards work.

If you want to code in DLC checks for DR, that's up to you @Pietrus69, but if not you'll need to change the effects to be something else.

[Zankoas]

@PPsyrius Totally agree, so I think the solution there is to change the minister effects to be something that works fine with or without the DLC. I'll take a look and see if anything fits well

[Zankoas]

And ministers sorted