Kaiserreich / Kaiserreich-4-Bug-Reports

Issue tracker for Kaiserreich for Hearts of Iron 4
110 stars 40 forks source link

QIE - Destroy Isolated Warlords focus for Republican Zhili #8365

Closed ggnixc closed 4 years ago

ggnixc commented 4 years ago

Quick questions HOI4 version: 1.9.3 Kaiserreich version: 0.12.2

Describe the change you would like:

Doing this focus does not give sufficient war goals for warlord nations in China. The only nations that the Zhili can declare on using the decisions are Shanxi, Song Zheyuan's Shandong Clique and the Ma Clique. The focus should give decisions to attack all warlords in China, or integrate and annex aligned warlords into the republic like Armament Sichuan.

Explain the reasoning behind this change:

If Manchu Qing can have decisions to attack pretty much every warlord like Liangguang, Sichuan, Shandong, Xinjiang or any remnants of the LEP, why can't the Zhili Republic do the same? There should be consistency in the QIE tag and both paths should be treated equally. Without decisions to attack warlords, the Zhili Republic is essentially a sitting duck waiting for the Fengtian to attack as it cannot declare any wars on its own to unify China until world tension is high enough.

Additional context or comments:

Below is an example code of the Zhili Republic's preconditions for war with Shandong:

_QIE_destroy_song_if_republic = { #if you pick yan to support the coup icon = generic_prepare_civil_war visible = { has_country_flag = QIE_coup_failed has_completed_focus = QIE_destroy_isolated_warlords can_declare_war_on = FROM FROM = { has_country_leader = { name = "Song Zheyuan" rulingonly = yes } } }

The Zhili Republic should be able to declare war regardless of whoever is in charge. It's not like they are ideologically aligned to Shanqing Tianguo or the Meatdog General.

Battletank09 commented 4 years ago

I want to add a suggestion on top of this. For some reason, Any Zhili can't attack Guangxi or Xinjiang if its ruled by Ma Ji or Jin Shuren who are both pro-Zhili, but then there's no option to invite them to your faction and integrate them afterwards. This seems like an oversight to the admittingly rare cases where you help Ma Ji win, but not Jin Shuren. Please add.

The lines of code relevent are under 'QIE_zhili_kill_SIK' and 'QIE_zhili_kill_GXC'

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it was created more than a month ago. Any dev is now free to relabelled, close or implement it.

Alpinia commented 4 years ago

Fixed.