Kaiserreich / Kaiserreich-4-Bug-Reports

Issue tracker for Kaiserreich for Hearts of Iron 4
110 stars 40 forks source link

GXC, PRC - Having both Victory Imminent and Momentum Lost #9879

Closed liach closed 4 years ago

liach commented 4 years ago

Quick questions OS: Windows HOI4 version: 1.9.3 Kaiserreich version: 0.13 List any other mods used: Were you using Steam? Were you in multiplayer? Which expansions do you NOT have?

Explanation of the issue: In Liangguang Civil War PRC can have both victory imminent and momentum lost.

Steps to reproduce:

  1. Play some other tag and wait for Liangguang Civil War to happen.

  2. Observe that both side may get "Momentum lost" and one side may get "Victory Imminent" as well.

Possible cause: In LEP wars the timeout effect is not always "Momentum Lost", but only if the tag has more surrender progress than its opponent. Should probably use the LEP mechanism where punishment is only when one side is losing more than the other.

Screenshots: PRC having both victory imminent and momentum lost hoi4_330

liach commented 4 years ago

Also these two tags can probably just use china_lost_momentum idea than GXC/PRC specific versions, or merge them for easier maintenance

Alpinia commented 4 years ago

Fixed in 0.14.

liach commented 4 years ago

Hmm I reported the wrong version, reproduced in 0.14 where Russian Socialist Republic got Frunze again. Will make another one with detailed instructions to reproduce this reliably.