Kaiserreich / Kaiserreich-DH

Home of the Kaiserreich mod for Darkest Hour
47 stars 25 forks source link

Misplaced modifiers in U25 policy decision event? #73

Closed mechu1205 closed 3 years ago

mechu1205 commented 3 years ago

Event 966667 in Mitteleuropa/Danubian Federation.txt is called "Right-wing Coalition decide it's policy", and allows U25 to select a set of bonuses. Now I've found something strange about the options:

event = {
id = 966667
random = no
country = U25
style = 2
persistent = yes
picture = "reichsrat"

name = "Right-wing Coalition decide it's policy"

...

action_b = {
ai_chance = 25
name = "Let us focus on defending our country from external threats"
command = { type = dissent value = 5 }
command = { type = set_domestic which = interventionism value = 9 }
command = { type = set_domestic which = professional_army value = 9 }
command = { type = set_domestic which = defense_lobby value = 9 }
command = { type = manpowerpool value = -150 }                      <--- ???
command = { type = supplies value = -500 }
}

...

action_d = {
ai_chance = 60
name = "Let us focus on strengthening our agriculture and industry!"
command = { type = domestic which = free_market value = -1 }
command = { type = manpowerpool value = 300 }            <--- ???
command = { type = construct which = IC where = -4 value = 1 }
command = { type = construct which = IC where = -4 value = 1 }
command = { type = gain_tech which = -1 }
command = { type = gain_tech which = -1 }
}
}

Now it seems very strange that mobilizing the country should decrease manpower, and focusing on economical development should increase it. It definitely looks like a mistake when you compare it to the options in Event 966662, "The Conservatives decide their policy".

event = {
id = 966662
random = no
country = U25
style = 2
persistent = yes
picture = "reichsrat"

name = "The Conservatives decide their policy"

...

action_a = {
ai_chance = 25
name = "Let us focus on defending our country from external threats"
command = { type = dissent value = 5 }
command = { type = domestic which = interventionism value = 2 }
command = { type = domestic which = professional_army value = 2 }
command = { type = domestic which = defense_lobby value = 2 }
command = { type = manpowerpool value = 150 }             <--- Manpower Gain
command = { type = supplies value = -2000 }
}

...

action_c = {
ai_chance = 60
name = "Let us focus on strengthening our agriculture and industry!"
command = { type = domestic which = free_market value = -1 }
command = { type = manpowerpool value = -40 }            <--- Manpower Loss
command = { type = construct which = IC where = -4 value = 1 }
command = { type = construct which = IC where = -4 value = 1 }
command = { type = gain_tech which = -1 }
command = { type = gain_tech which = -1 }
}
}

Also, the apostrophe in the phrase "it's policy" should be removed. The apostrophe is also present in the name for Event 966659, "Left-wing Coalition decides it's policy".

Maxian25 commented 3 years ago

Fixed.