search

Kaiteki-Fedi / Kaiteki

The comfy SNS client for everything, everywhere
https://kaiteki.app
GNU Affero General Public License v3.0
482 stars 31 forks source link

Include libhandy-1.so in AppImage #390

Open 0xdc opened 1 year ago

0xdc commented 1 year ago

What happened?

When trying to start the Kaiteki weekly-2023-21 AppImage, kaiteki cannot start without libhandy-1.so.0:

$ ./Kaiteki-x86_64.AppImage 
/tmp/.mount_KaitekVMS29c/kaiteki: error while loading shared libraries: libhandy-1.so.0: cannot open shared object file: No such file or directory

AppImages should contain copies of non-standard dynamic libraries, and I believe this qualifies as one.

Expected behavior

No response

How to reproduce

On a Linux x86_64 system without libhandy-1 installed:

  1. curl -L -o Kaiteki-x86_64.AppImage https://github.com/Kaiteki-Fedi/Kaiteki/releases/download/weekly-2023-21/Kaiteki-x86_64.AppImage
  2. chmod +x Kaiteki-x86_64.AppImage
  3. ./Kaiteki-x86_64.AppImage

What platform are you seeing the issue on?

Linux

Additional context

Workaround would be to install libhandy-1 as a system package.

Craftplacer commented 1 year ago

Good catch. Will fix soon.

AliceGrey commented 4 months ago

@Craftplacer pretty sure this was fixed by c3054e7. I can't replicate it.

Craftplacer commented 4 months ago

@Craftplacer pretty sure this was fixed by c3054e7. I can't replicate it.

It isn't fixed by that commit because AppImages expect you to ship copy of required libraries yourself. The commit only adds the dependency of libhandy in the build steps and documentation.