Kaixhin / dockerfiles

Compilation of Dockerfiles with automated builds enabled on the Docker Registry
https://hub.docker.com/u/kaixhin/
MIT License
504 stars 128 forks source link

ENV issue #3

Closed LijieTu closed 9 years ago

LijieTu commented 9 years ago

ENV PATH=/root/torch/install/bin:$PATH should be ENV PATH /root/torch/install/bin:$PATH in dockerfiles/cuda-torch-plus/Dockerfile

See here https://github.com/zeromq/jzmq/commit/5558dc0ff35ae1e5daa80983aee3c2eeb16f720c

Kaixhin commented 9 years ago

According to the documentation on Dockerfiles, this should be fine (and I like to use the = for consistency even if only one ENV variable is set).

If you are getting an error it's probably because of an error introduced in https://github.com/Kaixhin/dockerfiles/commit/71774d47bca11016195784809580e7e02acb0026, which should hopefully be resolved. Once the Docker image is rebuilt please try again.

Kaixhin commented 9 years ago

I've sorted out paths in the dependencies and tested fbcunn within the cuda-torch-plus image, so I'm now closing this issue.