KaizenGirl1111 / GSGrihSangini

A LinkedIn type platform but for low wage workers and maids!
gsg-rih-sangini-pi.vercel.app
MIT License
11 stars 19 forks source link

Pathway to ClientRequest #121

Closed mayank-del closed 2 years ago

mayank-del commented 2 years ago

πŸ› οΈ Fixes Issue #4

πŸ‘¨β€πŸ’» Changes proposed

βœ”οΈ Check List (Check all the applicable boxes)

πŸ“„ Note to reviewers

@KaizenGirl1111 maam, I connected WorkerLogin , WorkerSignup to backend and I made signup page to navigate to login and then after worker will login , He will render to clientrequest page , Is Idea is ok or not ?

πŸ“· Screenshots

KaizenGirl1111 commented 2 years ago

@mayank-del bro could you please fix the merge conflicts? Will review it asap

mayank-del commented 2 years ago

@mayank-del bro could you please fix the merge conflicts? Will review it asap

Sorry for little delay, I solved the conflicts

mayank-del commented 2 years ago

@KaizenGirl1111 maam ,conflicts resolved

mayank-del commented 2 years ago

@KaizenGirl1111 , maam check it .

KaizenGirl1111 commented 2 years ago

@KaizenGirl1111 , maam check it .

Mayank @mayank-del please check for merge conflicts

mayank-del commented 2 years ago

@KaizenGirl1111 maam , no merge it

mayank-del commented 2 years ago

@KaizenGirl1111 maam actually problem was that Whenever you merge any PR before my PR , it happens

mayank-del commented 2 years ago

@KaizenGirl1111 maam, Should I work more on your website, by arising new issues?

KaizenGirl1111 commented 2 years ago

@KaizenGirl1111 maam actually problem was that Whenever you merge any PR before my PR , it happens

Yes , got it :")

KaizenGirl1111 commented 2 years ago

@KaizenGirl1111 maam, Should I work more on your website, by arising new issues?

You can check the recent website And work on a functionality you think is missing Or, There are still some open issues Please check them

KaizenGirl1111 commented 2 years ago

Hey @mayank-del did you comment out the recent changes made by other developers πŸ₯² Please understand they've worked on the project for long and this is not the way to make a PR get merged!

ayush25102001 commented 2 years ago

Hey @mayank-del did you comment out the recent changes made by other developers πŸ₯² Please understand they've worked on the project for long and this is not the way to make a PR get merged!

Mam the project is not starting in localhost

mayank-del commented 2 years ago

Hey @mayank-del did you comment out the recent changes made by other developers πŸ₯² Please understand they've worked on the project for long and this is not the way to make a PR get merge.

No maam in your website , i added some functionalities, there were not any connection between frontend to backend

mayank-del commented 2 years ago

@ayush25102001 , if you are facing any issue just because of my PR , then feel free to connect with me in discord

@ayush25102001 , give me your discord id, I checked it many times, let me know, what you are doing and what error you are getting

ayush25102001 commented 2 years ago

@ayush25102001 , if you are facing any issue just because of my PR , then feel free to connect with me in discord

@ayush25102001 , give me your discord id, I checked it many times, let me what you are doing and what error you are getting

Hi, the frontend to backend parts are already done please see check by sending data to forms and checks the entries locally in Robo3T

mayank-del commented 2 years ago

@ayush25102001 , are you there??

ayush25102001 commented 2 years ago

@ayush25102001 , are you there??

Yep

mayank-del commented 2 years ago

@ayush25102001 , if you are facing any issue just because of my PR , then feel free to connect with me in discord @ayush25102001 , give me your discord id, I checked it many times, let me what you are doing and what error you are getting

Hi, the frontend to backend parts are already done please see check by sending data to forms and checks the entries locally in Robo3T

@ayush25102001 just see what changes I made , iI commented few variables to add new variables ,only declaration of variables were not creations.

mayank-del commented 2 years ago

@ayush25102001 , are you there??

Yep

Then ,come on discord , if you are having any issue , then tell me ,I am also watching, please dont make maam panic, just thing about her.

mayank-del commented 2 years ago

@KaizenGirl1111 maam , please trust me , i am correct

Hey @mayank-del did you comment out the recent changes made by other developers πŸ₯² Please understand they've worked on the project for long and this is not the way to make a PR get merged!

Maam please trust me , I am correct , he might be confused due to his system issues, it still starting perfectly in my system, if you will say I will upload working video

KaizenGirl1111 commented 2 years ago

hey sorry for the commotion @ayush25102001 @Siddhesh777 , I uncommitted the current commit, for now, please check if the website is working in the previous state. Also @mayank-del I understand this must be unintentional please check other issues and try to work on them without making changes to other contributors' code without their permission. Peace, wasn't a very big issue, have a good night guys

mayank-del commented 2 years ago

@KaizenGirl1111 maam, those developers are cheating you, they haven't linked frontend to backend yet , you can see on file changed what changes I did , they are just playing with my hardwork, If he is true , then why not he is coming to discord, such things are easy maam , trust me maam, he is himself confused , just because of 1 developer , how you can think like that. Don't be panic maam , I will never let your trust down.

KaizenGirl1111 commented 2 years ago

I'll check the website again tomorrow, And don't worry I won't let anyone's score go down @mayank-del . Till now, there has been improvement into the site by all the contributors effort

mayank-del commented 2 years ago

I'll check the website again tomorrow, And don't worry I won't let anyone's score go down @mayank-del . Till now, there has been improvement into the site by all the contributors effort

Thank you maam, actually, ayush got confused in mongoose database , there you can see big code is commented , actually that was my written codeπŸ˜‚πŸ˜‚ , i wrote that code for my practice, but it was having some issue, so i commented it and restored your code but I forgot to delete my commented code, so he thought that I commented big codes ,but that was mine, you can delete that commented code anytime.

ayush25102001 commented 2 years ago

Any updates @KaizenGirl1111 mam

mayank-del commented 2 years ago

@ayush25102001 , can you tell me one thing , you had created frontend to backend worker login signup join or front and backend worker login signup??

ayush25102001 commented 2 years ago

@ayush25102001 , can you tell me one thing , you had created frontend to backend worker login signup join or front and backend worker login signup??

Run the project and check

KaizenGirl1111 commented 2 years ago

I'll check the website again tomorrow, And don't worry I won't let anyone's score go down @mayank-del . Till now, there has been improvement into the site by all the contributors effort

Thank you maam, actually, ayush got confused in mongoose database , there you can see big code is commented , actually that was my written codeπŸ˜‚πŸ˜‚ , i wrote that code for my practice, but it was having some issue, so i commented it and restored your code but I forgot to delete my commented code, so he thought that I commented big codes ,but that was mine, you can delete that commented code anytime.

  • Ok @mayank-del I see what happened there, so it was your comment

KaizenGirl1111 commented 2 years ago

I had uncommitted the last commit, so is the issue still persisting Ayush?

mayank-del commented 2 years ago

I had uncommitted the last commit, so is the issue still persisting Ayush?

I'll check the website again tomorrow, And don't worry I won't let anyone's score go down @mayank-del . Till now, there has been improvement into the site by all the contributors effort

Thank you maam, actually, ayush got confused in mongoose database , there you can see big code is commented , actually that was my written codeπŸ˜‚πŸ˜‚ , i wrote that code for my practice, but it was having some issue, so i commented it and restored your code but I forgot to delete my commented code, so he thought that I commented big codes ,but that was mine, you can delete that commented code anytime.

Ok @mayank-del I see what happened there, so it was your comment

I'll check the website again tomorrow, And don't worry I won't let anyone's score go down @mayank-del . Till now, there has been improvement into the site by all the contributors effort

Thank you maam, actually, ayush got confused in mongoose database , there you can see big code is commented , actually that was my written codeπŸ˜‚πŸ˜‚ , i wrote that code for my practice, but it was having some issue, so i commented it and restored your code but I forgot to delete my commented code, so he thought that I commented big codes ,but that was mine, you can delete that commented code anytime.

Ok @mayank-del I see what happened there, so it was your comment

No, maam, I just want to say that he misunderstood my code.

Let me tell you everything that i have done in this PR

First of all, in your worker.js , where schema is present , you can see category attribute was there, which i commented . Now, I commented that attribute just because of the fact that you are taking email from frontend and storing it in in category array, email is not an array attribute and email is single item ,name was also invalid and format was also not correct.If you will do frontend to backend connection , it will give you a huge list of errors. I corrected it and added proper email attribute there instead of category array. Then i made frontend to backend connection which was not present on your repo, then i make it navigate to login page and connected it to backend and after login ,i made it to navigate to client request page, so that , if you want to add any more page ,you can add in between login and client request page. I can only make client request page ,without touching your backend rest api ,but maam ,very honestly I am saying ,it would not work , if someone would try to connect it, it would give him errors , whatever i am saying ,I have proper proves with me, you can verify by yourself , I haven't done anything to for gaining extra points maam, I did these extra backend frontend fixes , so I thought to clear some extra bugs and add backend -frontend connections just for you help but if helping someone by doing extra labour will return such type of responses , it really hurt me.

mayank-del commented 2 years ago

I had uncommitted the last commit, so is the issue still persisting Ayush?

I'll check the website again tomorrow, And don't worry I won't let anyone's score go down @mayank-del . Till now, there has been improvement into the site by all the contributors effort

Thank you maam, actually, ayush got confused in mongoose database , there you can see big code is commented , actually that was my written codeπŸ˜‚πŸ˜‚ , i wrote that code for my practice, but it was having some issue, so i commented it and restored your code but I forgot to delete my commented code, so he thought that I commented big codes ,but that was mine, you can delete that commented code anytime.

Ok @mayank-del I see what happened there, so it was your comment

I'll check the website again tomorrow, And don't worry I won't let anyone's score go down @mayank-del . Till now, there has been improvement into the site by all the contributors effort

Thank you maam, actually, ayush got confused in mongoose database , there you can see big code is commented , actually that was my written codeπŸ˜‚πŸ˜‚ , i wrote that code for my practice, but it was having some issue, so i commented it and restored your code but I forgot to delete my commented code, so he thought that I commented big codes ,but that was mine, you can delete that commented code anytime.

Ok @mayank-del I see what happened there, so it was your comment

No, maam, I just want to say that he misunderstood my code.

Let me tell you everything that i have done in this PR

First of all, in your worker.js , where schema is present , you can see category attribute was there, which i commented . Now, I commented that attribute just because of the fact that you are taking email from frontend and storing it in in category array, email is not an array attribute and email is single item ,name was also invalid and format was also not correct.If you will do frontend to backend connection , it will give you a huge list of errors. I corrected it and added proper email attribute there instead of category array. Then i made frontend to backend connection which was not present on your repo, then i make it navigate to login page and connected it to backend and after login ,i made it to navigate to client request page, so that , if you want to add any more page ,you can add in between login and client request page. I can only make client request page ,without touching your backend rest api ,but maam ,very honestly I am saying ,it would not work , if someone would try to connect it, it would give him errors , whatever i am saying ,I have proper proves with me, you can verify by yourself , I haven't done anything to for gaining extra points maam, I did these extra backend frontend fixes because I thought to clear some extra bugs and add backend -frontend connections just for you help but if helping someone by doing extra labour will return such type of responses , it really hurt me.