search

Kakadu / lablqml

Interfacing Qt/QML with OCaml. Formely known as lablqt
http://kakadu.github.io/lablqml
GNU Lesser General Public License v2.1
159 stars 17 forks source link

Fix configure version checks #59

Closed ghost closed 6 years ago

ghost commented 6 years ago

Previous version doesn't work with more one digits in subparts. Function based on https://stackoverflow.com/a/24067243

Fixes my issue, where I have Qt 5.10.0 but current configure things that is smaller than 5.2.0.

Kakadu commented 6 years ago

I think that -V will not work on Mac... but there is a workaround https://github.com/ocaml/opam-repository/commit/f4d5ee8686742558df2c28ad7a30faa08e049e20 What do you think?

ghost commented 6 years ago

I will try that portable version tomorrow and let you know.

ghost commented 6 years ago

Ok, patched the function and commit message. Is it ok?