KakaoCup / Compose

Nice and simple DSL for Espresso Compose UI testing in Kotlin
https://kakaocup.github.io/Compose/
Apache License 2.0
146 stars 15 forks source link

0.3 version requeries java 17 #66

Closed kozaxinan closed 5 months ago

kozaxinan commented 11 months ago

https://github.com/KakaoCup/Compose/pull/54 this change introduced java 17 as build jdk. but there is no need to update source and binary compability to java 17 at the moment. this will force users to match java target.

addind java and kotlin targets for java 8 or 11 could be enough.

Vacxe commented 8 months ago

https://developer.android.com/build/releases/gradle-plugin

Screenshot 2024-03-05 at 9 40 14 am

Please take a look for Gradle-AGP-Java compatibility

kozaxinan commented 8 months ago

Isn't that requirement just for JDK? Source code compatibility and which JDK is being used to compile should be different topics, right? Original change could just update the jdk.

We use new agp with java 11 compatibility and jdk 17 for a while. We updated our source compatibility to 17 recently.

This issue is not a blocker for us any more.

Feel free to close.