search

KakaoCup / Kakao

Nice and simple DSL for Espresso in Kotlin
https://kakaocup.github.io/Kakao/
Apache License 2.0
325 stars 28 forks source link

Remove Guava dependency #129

Closed kubode closed 1 month ago

kubode commented 1 month ago

Guava has some dependency issues as mentioned at here.

Guava has been introduced in Kakao 3.6.0 at https://github.com/KakaoCup/Kakao/commit/fd7edfd89913eec0429f18e465dd435353068242. Bumping up to 3.6.0 caused the dependency resolution issue on our project. So we want to remove Guava from the dependency of Kakao.

Unlimity commented 1 month ago

Hi there. In a case like this, you can override transient dependency in your own project (you can look up how to do that here - https://stackoverflow.com/questions/30728533/gradle-override-transitive-dependency-by-version-classifier). But on the other hand, I don't see a reason why we imported it in the first place, as it seems from this PR that we use only 1 function of the whole library which can be replaced by Kotlin STD function. @Vacxe wdyt?

Vacxe commented 1 month ago

100% agree with replacement. If all checks passed I'll be happy to remove that dependency. Thanks for letting us know @kubode ! Cheers.

Vacxe commented 1 month ago

Released 3.6.2