Closed hongwei-bai closed 2 years ago
@hongwei-bai I terribly sorry, but I think will be better to have two separates
ItalicStyleMatcher()
and BoldStyleMatcher()
without any parameters for constructor
and then for negative assertion just use not(<Matcher>)
With this approach we will have single responsibility + avoiding Boolean in constructor
@hongwei-bai I terribly sorry, but I think will be better to have two separates
ItalicStyleMatcher()
andBoldStyleMatcher()
without any parameters for constructor and then for negative assertion just usenot(<Matcher>)
With this approach we will have single responsibility + avoiding Boolean in constructor
sure np @Vacxe. tbh I was swinging betweens the two. will make the changes. Thanks! 👍
Hi @Vacxe , feel typeface match might be quite strict sometimes(has to match style and weight too), maybe add this one as well for a few simple scenarios?