Use dedicated ViewPager/ViewPager2 actions

KakaoCup / Kakao

Nice and simple DSL for Espresso in Kotlin

https://kakaocup.github.io/Kakao/

Apache License 2.0

325 stars 28 forks source link

Use dedicated ViewPager/ViewPager2 actions #66

Closed audkar closed 1 year ago

audkar commented 1 year ago

General SwipeableActions were used before that were not fully synchronized with ViewPager's state. Tests were flaky in rare conditions because of that.

Not to break public API I have added new methods. But IMO it would be good to get rid of SwipeableActions methods from KViewPager because:

ViewPager doesn't support swipeDown/Up
Are not fully synchronized by Espresso. Since swipe actions ends earlier then ViewPager settles. That makes tests flaky

closes #65

Vacxe commented 1 year ago

@audkar hey mate appreciate for the contribution! Can't disagree with redundant swipeUp and swipeDown. Could you remove inheritance from SwipeableActions and create temporary copy-paste method with the same signature with @Deprecated annotation please? Also tiny fixes for empty lines.

audkar commented 1 year ago

Fixed