Request: Use Fetch to Replace Phi

Kakulukian / youtube-transcript

Fetch transcript from a youtube video

240 stars 51 forks source link

Request: Use Fetch to Replace Phi #12

Closed mefengl closed 5 months ago

mefengl commented 6 months ago

I've already implemented this; it appears straightforward, requiring 10–15 lines of code to be changed. If you'd like, I can create a pull request for it.

Additionally, I noticed that this repository lacks a proper license file. I'm not sure if you're aware of this.

jdp8 commented 6 months ago

Hello! May I know specifically what you changed? I'm trying to run this in the browser and I changed the p() calls to fetch() but it's still not working.

mefengl commented 6 months ago

@jdp8 see https://github.com/mefengl/youtube-transcript/commit/7014a3df9c2f75398363866f81f02742fe8a38a1

jdp8 commented 6 months ago

@mefengl Thank you so much!

santiq commented 5 months ago

Please @mefengl create a PR

Ping @Kakulukian

mefengl commented 5 months ago

@santiq here: https://github.com/Kakulukian/youtube-transcript/pull/13 it may still need some work, contributions are welcome if anyone is willing